Removing internal tests from hcsshim's cri-containerd tests #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
reviewed
Jan 24, 2024
|
LGTM after addressing Hamza's comments. |
helsaawy
approved these changes
Feb 5, 2024
yyatmsft
commented
Feb 8, 2024
yyatmsft
commented
Feb 15, 2024
test/cri-containerd/test-images/nanoserver-gracefultermination-repro/latest/delayed-shutdown.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we work towards further separating the cri-containerd and azcri-containerd tests, we need to first remove the internal only tests from the shim repo, as they are not being run anyways, and it makes it easier to upstream the external tests in the future.
Validated by running external package build with test run on ADO.