Create UVM honoring NUMA configuration parameters #2198
Merged
+565
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we remove any schemas that aren't actively being used in this PR? I'm fine with including some extra fields for some of the leaf node schemas but for larger schemas like |
… is configured on same NUMA node as the device. Expose SLIT configuration to UVM to gather NUMA node distances. Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
apurv15
force-pushed
the
User/apurvbarve/NUMA
branch
from
ece0a9e
to
17d76db
Compare
anmaxvl
reviewed
Jul 12, 2024
There was a problem hiding this comment.
a few comments, similar to what @katiewasnothere already mentioned.
anmaxvl
reviewed
Jul 12, 2024
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
anmaxvl
reviewed
Jul 16, 2024
anmaxvl
reviewed
Jul 16, 2024
anmaxvl
reviewed
Jul 16, 2024
anmaxvl
reviewed
Jul 16, 2024
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
…or better readability Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
anmaxvl
reviewed
Jul 16, 2024
anmaxvl
reviewed
Jul 16, 2024
anmaxvl
reviewed
Jul 16, 2024
katiewasnothere
approved these changes
Jul 16, 2024
Signed-off-by: Apurv Barve <apurvbarve@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose NUMA config to containers. Use HCS device affinity so that UVM is configured on same NUMA node as the device. Expose SLIT configuration to UVM to gather NUMA node distances.
Changes under internal/hcs/schema2 are for using new HCS APIs related to NUMA HCS parameters and its dependencies. These files are auto-generated and could be skipped for a thorough review.
Other changes are business logic and should be reviewed thoroughly.
Some tests around device affinity and Hybrid/Virtual MemoryBackingType are pending. Creating PR to get early feedback.