Fix FileAttributes size to work across all platforms #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asherkariv
approved these changes
Aug 2, 2018
|
You will have to revendor go-winio to do this. Can you just open an issue and @jhowardmsft or myself can do this one since we will need a new release of go-winio. |
|
@jterry75 where do you want that issue to be created? Here, on go-winio or on the moby/moby? |
|
Open it here. |
|
Ok, here is the requested issue: #279 Is there anything blocking completion of this change? |
|
Yes this change doesnt build because of the vendor problem I asked you to submit the issue for :). Will need to update that part of this before I can merge this change. Thanks |
|
Merged |
dcantah
pushed a commit
to dcantah/hcsshim
that referenced
this pull request
Mar 17, 2021
devicemapper: Code to create and destroy dm devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a corresponding change to the following PR: microsoft/go-winio#88