Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ttrpc to fix status check error. #703

Merged
merged 1 commit into from Sep 25, 2019
Merged

Update ttrpc to fix status check error. #703

merged 1 commit into from Sep 25, 2019

Conversation

Random-Liu
Copy link
Contributor

@Random-Liu Random-Liu commented Sep 25, 2019 •
edited

I see a lot of no status provided on response errors right now:

time="2019-09-25T04:25:24.786235700Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:25.649597000Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:26.795661200Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:28.651497300Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:29.810168200Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:32.664288500Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:33.820457100Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:37.670542700Z" level=error msg="forward event" error="no status provided on response"
time="2019-09-25T04:25:38.829335400Z" level=error msg="forward event" error="no status provided on response"

See containerd/ttrpc#46

@jterry75

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu
Update ttrpc to fix status check error.
fc97d61 
Signed-off-by: Lantao Liu <lantaol@google.com>
jterry75
jterry75 approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

kevpar
kevpar approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar kevpar merged commit 7a7dcfb into microsoft:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevpar kevpar kevpar approved these changes

@jterry75 jterry75 jterry75 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Random-Liu @kevpar @jterry75