Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cimfs support: Add cimfs writer #927

Merged
merged 1 commit into from
Jul 15, 2023
Merged

cimfs support: Add cimfs writer #927

merged 1 commit into from
Jul 15, 2023

Conversation

ambarve
Copy link
Contributor

@ambarve ambarve commented Jan 19, 2021

This PR is one of the multiple PRs that add support for using cimfs based layers for containers. This PR adds the go wrappers over cimfs writer functions exported by cimfs.dll and also includes a cimfs reader that can directly read data from cimfs files.

Note: The cimfs reader was mostly written by John and I have taken it as it is from his branch with some minor changes.

@ambarve ambarve requested a review from a team January 19, 2021 22:59
@ambarve ambarve force-pushed the cimfs_pr_1 branch 2 times, most recently from af09396 to 0a57a55 Compare January 19, 2021 23:07
dcantah
dcantah reviewed Jan 20, 2021
View reviewed changes
osversion/windowsbuilds.go Outdated Show resolved Hide resolved
@dcantah
Copy link
Contributor

dcantah commented Jan 20, 2021 •
edited
Loading

There's a couple of commented out struct fields that are unclear if they're placeholders for something or just leftovers that forgot to be removed

dcantah
dcantah reviewed Mar 4, 2021
View reviewed changes
internal/cimfs/mount_cim.go Outdated Show resolved Hide resolved
dcantah
dcantah reviewed Mar 4, 2021
View reviewed changes
internal/winapi/orapi.go Outdated Show resolved Hide resolved
@ambarve ambarve force-pushed the cimfs_pr_1 branch 2 times, most recently from 9b42ea3 to c790049 Compare March 22, 2021 17:16
dcantah
dcantah reviewed Mar 31, 2021
View reviewed changes
internal/cimfs/common.go Outdated Show resolved Hide resolved
@ambarve ambarve mentioned this pull request Apr 4, 2023
Open
4 tasks
@ambarve ambarve changed the title cimfs support: Add cimfs reader/writers cimfs support: Add cimfs writer Apr 17, 2023
@ambarve ambarve force-pushed the cimfs_pr_1 branch 3 times, most recently from 9f04552 to c9b6c5a Compare April 25, 2023 17:44
msscotb
msscotb requested changes May 5, 2023
View reviewed changes
pkg/cimfs/cim_writer_windows.go Show resolved Hide resolved
pkg/cimfs/cim_writer_windows.go Outdated Show resolved Hide resolved
@ambarve ambarve force-pushed the cimfs_pr_1 branch 2 times, most recently from c6c617f to 559a7b9 Compare June 2, 2023 19:14
@ambarve ambarve force-pushed the cimfs_pr_1 branch 2 times, most recently from 8bf2a65 to 5cfabf0 Compare July 12, 2023 04:18
@ambarve ambarve force-pushed the cimfs_pr_1 branch 2 times, most recently from d9f0b7a to 2a4c42b Compare July 14, 2023 22:54
@ambarve
cimfs: Add cimfs writer
4298d3d 
Add go wrappers over cimfs writer functions exported by cimfs.dll.

Signed-off-by: Amit Barve <ambarve@microsoft.com>
@ambarve ambarve merged commit 5e97eb3 into microsoft:main Jul 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah approved these changes

@katiewasnothere katiewasnothere katiewasnothere approved these changes

@msscotb msscotb msscotb approved these changes

Assignees

@katiewasnothere katiewasnothere

@msscotb msscotb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ambarve @dcantah @katiewasnothere @msscotb