Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mebristo/refactor run id types #129

Merged
merged 24 commits into from Nov 1, 2021
Merged

Conversation

mebristo
Copy link
Member

@mebristo mebristo commented Oct 7, 2021

Make the following changes to command line args for himl-tensorboard and himl-download:

  • Replace ArgumentParser with parametrized class
  • replace run_id and run_recovery_id with --run which can be one or more of either type
  • keep experiment (name) arg. If neither --run nor --experiment is provided, defaults to searching for a most_recent_run file

update "get_run" functions in line with new command line args:

  • one function for getting Run objects from run ids/ run recovery ids
  • separate function for getting Run from experiment

Side change:
Update docstring & signature for download_checkpoint to highlight that it can be called to download one checkpoint file, as well as a folder.

@mebristo mebristo marked this pull request as ready for review October 15, 2021 16:23
docs/source/commandline_tools.md Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl_download.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl_download.py Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl_download.py Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl_tensorboard.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/utils.py Show resolved Hide resolved
hi-ml-azure/src/health_azure/utils.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/utils.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/utils.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/utils.py Outdated Show resolved Hide resolved
JonathanTripp
JonathanTripp previously approved these changes Oct 28, 2021
@mebristo mebristo merged commit e89e7d7 into main Nov 1, 2021
@mebristo mebristo deleted the mebristo/refactor_run_id_types branch November 1, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create parametrized class for enforcing types & ranges in argument parsing
3 participants