Add image load profiling #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 19, 2021 12:59
mebristo
reviewed
Oct 25, 2021
environment.yml
Outdated
| @@ -7,5 +7,7 @@ dependencies: | |||
| - python=3.7.3 | |||
| - pytorch=1.8.0 | |||
| - pip: | |||
| - line_profiler==3.3.1 | |||
There was a problem hiding this comment.
Should these be moved into one of the requirements files?
There was a problem hiding this comment.
These requirements are only needed for running the slide profiling, but they are needed for pyright so are included in this environment, which is only used by pyright, so it feels better to have them here... Maybe, one day, monai will be a run_requirement, but it isn't yet.
hi-ml/testhiml/testhiml/utils/slide_image_loading/run_profile_load_image.py
Outdated
Show resolved
Hide resolved
hi-ml/testhiml/testhiml/utils/slide_image_loading/src/Histopathology/datasets/panda_dataset.py
Outdated
Show resolved
Hide resolved
.../testhiml/utils/slide_image_loading/src/Histopathology/preprocessing/create_tiles_dataset.py
Outdated
Show resolved
Hide resolved
mebristo
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.