Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix function to compute bounding box #311

Merged
merged 7 commits into from
Apr 21, 2022
Merged

BUG: Fix function to compute bounding box #311

merged 7 commits into from
Apr 21, 2022

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented Apr 20, 2022 •
edited
Loading

Related to #310.

@fepegar fepegar marked this pull request as ready for review April 20, 2022 14:18
@fepegar fepegar enabled auto-merge (squash) April 20, 2022 14:27
dccastro
dccastro requested changes Apr 20, 2022
View reviewed changes
hi-ml/src/health_ml/utils/box_utils.py Outdated Show resolved Hide resolved
hi-ml/src/health_ml/utils/box_utils.py Show resolved Hide resolved
hi-ml/testhiml/testhiml/test_box_utils.py Outdated Show resolved Hide resolved
@fepegar fepegar requested a review from dccastro April 20, 2022 17:15
dccastro
dccastro previously approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@dccastro dccastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff; thanks @fepegar!

dccastro
dccastro previously approved these changes Apr 20, 2022
View reviewed changes
@fepegar fepegar merged commit 3ac07de into main Apr 21, 2022
@fepegar fepegar deleted the 310-fix-get-bounding-box branch April 21, 2022 10:10
@fepegar
Copy link
Contributor Author

fepegar commented Apr 21, 2022

Thanks for your reviews!

@fepegar fepegar mentioned this pull request Apr 28, 2022
Merged
fepegar added a commit that referenced this pull request May 23, 2022
@fepegar
BUG: Fix function to compute bounding box (#311)
38e9e06 
* Add failing tests

* Fix get_bounding_box
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dccastro dccastro dccastro approved these changes

@harshita-s harshita-s harshita-s approved these changes

@vale-salvatelli vale-salvatelli Awaiting requested review from vale-salvatelli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fepegar @dccastro @harshita-s