Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add Codecov badge to README #343

Merged
merged 1 commit into from
May 17, 2022
Merged

DOC: Add Codecov badge to README #343

merged 1 commit into from
May 17, 2022

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented May 16, 2022

It looks like this:

codecov

@fepegar fepegar changed the title Add Codecov badge to README DOC: Add Codecov badge to README May 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #343 (792be72) into main (7ddb45d) will increase coverage by 4.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   76.74%   80.85%   +4.11%     
==========================================
  Files          64       28      -36     
  Lines        5629     2382    -3247     
  Branches      895      352     -543     
==========================================
- Hits         4320     1926    -2394     
+ Misses       1117      354     -763     
+ Partials      192      102      -90     
Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/himl_tensorboard.py
...stopathology/src/histopathology/utils/wsi_utils.py
...opathology/src/histopathology/models/transforms.py
...ology/src/histopathology/datasets/panda_dataset.py
hi-ml-azure/src/health_azure/himl_download.py
...src/histopathology/datasets/panda_tiles_dataset.py
...opathology/src/histopathology/utils/layer_utils.py
hi-ml-azure/src/health_azure/traverse.py
...histopathology/datasets/tcga_crck_tiles_dataset.py
hi-ml-azure/src/health_azure/datasets.py
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddb45d...792be72. Read the comment docs.

@fepegar
Copy link
Contributor Author

fepegar commented May 16, 2022

@ant0nsc do you know why Codecov might be reporting a large difference in coverage for this? Also, why is coverage uploaded twice in the build workflow? I missed that in the PR.

- name: Upload coverage report to Codecov
if: ${{ matrix.packageName == '*.whl' }}
uses: codecov/codecov-action@v2
with:
name: ${{ matrix.folder }}

- name: Upload coverage report to Codecov
if: ${{ matrix.packageName == '*.whl' }}
uses: codecov/codecov-action@v2
with:
name: ${{ matrix.folder }}

@fepegar
Copy link
Contributor Author

fepegar commented May 16, 2022

Apparently, the difference shown here might have been "a timing issue".

@ant0nsc
Copy link
Collaborator

ant0nsc commented May 16, 2022

@fepegar , Uploading is happening twice because first we do it for hi-ml and hi-ml-azure (matrix), and then in line 262 for the histo folder. However... For this run, there is no sign of results from hi-ml-azure? (screenshot from https://app.codecov.io/gh/microsoft/hi-ml/compare/343/tree)
image
Previous run correctly had numbers also for hi-ml-azure.

@fepegar
Copy link
Contributor Author

fepegar commented May 17, 2022

Thanks for clarifying. No idea why that happened! It looks ok for more recent commits.

@fepegar fepegar merged commit aaed5cb into main May 17, 2022
@fepegar fepegar deleted the add-codecov-badge branch May 17, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants