Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STYLE: Ensure all files end with a newline #347

Merged
merged 1 commit into from
May 17, 2022
Merged

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented May 17, 2022

Picked up by pre-commit.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #347 (1ae32a3) into main (7ddb45d) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   76.74%   76.85%   +0.10%     
==========================================
  Files          64       64              
  Lines        5629     5629              
  Branches      895      895              
==========================================
+ Hits         4320     4326       +6     
+ Misses       1117     1112       -5     
+ Partials      192      191       -1     
Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 97.91% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddb45d...1ae32a3. Read the comment docs.

@fepegar fepegar enabled auto-merge (squash) May 17, 2022 12:50
@mebristo
Copy link
Member

I wonder why these weren't picked up by the VS Code setting 'insertFinalNewline'?

@fepegar
Copy link
Contributor Author

fepegar commented May 17, 2022

I wonder why these weren't picked up by the VS Code setting 'insertFinalNewline'?

I suppose either the committers were not using VS Code or they were not using the proper workspace. One more reason to decouple formatting from IDEs.

@fepegar fepegar merged commit 2d0c629 into main May 17, 2022
@fepegar fepegar deleted the ensure-files-endline branch May 17, 2022 13:17
@fepegar fepegar mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants