Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Separate workflow for histopathology #354

Merged
merged 15 commits into from
May 18, 2022
Merged

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented May 17, 2022

  • Create separate test pipeline for the histo folder
  • Simplify Makefile for histo
  • Add file trigger conditions for all PR workflows

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #354 (7d64a63) into main (7ddb45d) will increase coverage by 1.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   76.74%   78.58%   +1.84%     
==========================================
  Files          64       88      +24     
  Lines        5629     6776    +1147     
  Branches      895     1054     +159     
==========================================
+ Hits         4320     5325    +1005     
- Misses       1117     1223     +106     
- Partials      192      228      +36     
Impacted Files Coverage Δ
...hology/src/histopathology/datasets/base_dataset.py 59.01% <0.00%> (-1.17%) ⬇️
.../src/SSL/lightning_modules/ssl_online_evaluator.py 89.79% <0.00%> (ø)
...logy/src/SSL/lightning_modules/byol/byol_module.py 97.18% <0.00%> (ø)
...-histopathology/src/SSL/configs/CXR_SSL_configs.py 100.00% <0.00%> (ø)
...ml-histopathology/src/SSL/data/transforms_utils.py 100.00% <0.00%> (ø)
hi-ml-histopathology/src/SSL/lightning_metrics.py 72.27% <0.00%> (ø)
.../SSL/lightning_modules/byol/byol_moving_average.py 100.00% <0.00%> (ø)
...l-histopathology/src/SSL/data/dataset_cls_utils.py 93.33% <0.00%> (ø)
...logy/src/SSL/lightning_modules/byol/byol_models.py 100.00% <0.00%> (ø)
...src/SSL/lightning_modules/ssl_classifier_module.py 90.90% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddb45d...7d64a63. Read the comment docs.

@fepegar fepegar self-requested a review May 18, 2022 08:27
@ant0nsc ant0nsc merged commit 3e14cce into main May 18, 2022
@ant0nsc ant0nsc deleted the antonsc/separate_workflows branch May 18, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split test pipelines for hi-ml and hi-ml-azure from those for histopathology
3 participants