Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add utils to upload annotations to the Digital Slide Archive #373

Merged
merged 13 commits into from
May 27, 2022

Conversation

fepegar
Copy link
Contributor

@fepegar fepegar commented May 23, 2022

No description provided.

@fepegar fepegar force-pushed the girder-api branch 3 times, most recently from d51b562 to 1c6b7d5 Compare May 23, 2022 12:49
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #373 (b10dd50) into main (b8eef6b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
hi-ml-histopathology 75.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@fepegar fepegar marked this pull request as ready for review May 23, 2022 13:29
Copy link
Member

@dccastro dccastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, my only major suggestion is to add at least some basic documentation to these classes, constructors, and public methods.

Copy link
Contributor

@harshita-s harshita-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for implementing the utils to upload annotations to DSA. My only major comment is around documentation, perhaps you could add some docstrings to the classes/ methods?

@fepegar fepegar marked this pull request as draft May 24, 2022 08:50
fepegar added 13 commits May 27, 2022 10:48
Fix annotation class and add third dimension

Add support for passing API URL and key programmatically

Add method to get item ID from folder and file names

Add some typing hints

Add convenience functions

Stop rescaling by default

Add script to upload test outputs to the DSA

Add option to limit the number of processed slides

Add temporary argument --folder-name

Use tqdm to log errors for now

Update version of girder-client

Refactor utils by adding a RunOutputs class

Add support to choose the search mode

Read tile size from hparams YAML

Infer tile size from outputs CSV

Fix little bugs

Use latest version of Girder client

Update Girder utils to use left, top, right, bottom

Modify help message

Remove unused method to get hparams YAML

Remove default URL

Use double quotes for strings

Remove unused method to open YAML files

Remove unused argument

Undo changes to preprocessing module
@fepegar fepegar requested a review from dccastro May 27, 2022 14:54
@fepegar fepegar marked this pull request as ready for review May 27, 2022 17:47
@fepegar fepegar merged commit 31c4b4f into main May 27, 2022
@fepegar fepegar deleted the girder-api branch May 27, 2022 17:48
@fepegar
Copy link
Contributor Author

fepegar commented May 27, 2022

Thanks for reviewing, @dccastro and @harshita-s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants