-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add utils to upload annotations to the Digital Slide Archive #373
Conversation
d51b562
to
1c6b7d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, my only major suggestion is to add at least some basic documentation to these classes, constructors, and public methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for implementing the utils to upload annotations to DSA. My only major comment is around documentation, perhaps you could add some docstrings to the classes/ methods?
Fix annotation class and add third dimension Add support for passing API URL and key programmatically Add method to get item ID from folder and file names Add some typing hints Add convenience functions Stop rescaling by default Add script to upload test outputs to the DSA Add option to limit the number of processed slides Add temporary argument --folder-name Use tqdm to log errors for now Update version of girder-client Refactor utils by adding a RunOutputs class Add support to choose the search mode Read tile size from hparams YAML Infer tile size from outputs CSV Fix little bugs Use latest version of Girder client Update Girder utils to use left, top, right, bottom Modify help message Remove unused method to get hparams YAML Remove default URL Use double quotes for strings Remove unused method to open YAML files Remove unused argument Undo changes to preprocessing module
Thanks for reviewing, @dccastro and @harshita-s! |
No description provided.