ENH: Select top and bottom tiles on the fly #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout_a_fixed_tile_count
…g_without_a_fixed_tile_count
…hout_a_fixed_tile_count
|
I've now reverted the bot's commits. Again, I'm very sorry, @kenza-bouzid! |
No worries, thanks @fepegar for the fix! |
ant0nsc
approved these changes
Jun 6, 2022
hi-ml-histopathology/src/histopathology/configs/classification/BaseMIL.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/histopathology/utils/top_bottom_tiles_utils.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/histopathology/utils/top_bottom_tiles_utils.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/histopathology/utils/top_bottom_tiles_utils.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/histopathology/utils/top_bottom_tiles_utils.py
Outdated
Show resolved
Hide resolved
hi-ml-histopathology/src/histopathology/utils/top_bottom_tiles_utils.py
Outdated
Show resolved
Hide resolved
…_utils.py Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
…_utils.py Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
…_utils.py Co-authored-by: Anton Schwaighofer <antonsc@microsoft.com>
dccastro
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Tremendous accomplishment here, @kenza-bouzid! Now the API looks much cleaner and is easier to understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid plotting top and bottom tiles by reading them from png files, we now select these tiles on the fly for each batch in min and max heaps and then plot them from their respective tensors. Main contributions: