-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Incorporate additional smoke tests #532
Conversation
…rovide custom SSL checkpoint
…to/more_smoke_tests
…to/more_smoke_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good in terms of functionality. But there's some opportunity for removing duplication in the YAML files now, to increase long term maintainability of the tests. Move some of the repeated bits to a Github action or a Makefile?
Good point. Have added a GH action to replace the duplicate code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Incorporate additional smoke tests into the PR github workflow
This currently does not include the smoke test for TcgaCrckSSLMIL since we first must include a way to provide custom SSL checkpoint