Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Incorporate additional smoke tests #532

Merged
merged 17 commits into from
Jul 29, 2022
Merged

Conversation

mebristo
Copy link
Member

@mebristo mebristo commented Jul 21, 2022

Incorporate additional smoke tests into the PR github workflow

This currently does not include the smoke test for TcgaCrckSSLMIL since we first must include a way to provide custom SSL checkpoint

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #532 (7515724) into main (87237db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
hi-ml-cpath 77.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mebristo mebristo changed the title Incorporate additional smoke tests TEST: Incorporate additional smoke tests Jul 27, 2022
@mebristo mebristo marked this pull request as ready for review July 27, 2022 08:26
Copy link
Collaborator

@ant0nsc ant0nsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good in terms of functionality. But there's some opportunity for removing duplication in the YAML files now, to increase long term maintainability of the tests. Move some of the repeated bits to a Github action or a Makefile?

@mebristo
Copy link
Member Author

Looking good in terms of functionality. But there's some opportunity for removing duplication in the YAML files now, to increase long term maintainability of the tests. Move some of the repeated bits to a Github action or a Makefile?

Good point. Have added a GH action to replace the duplicate code

Copy link
Contributor

@peterhessey peterhessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@mebristo mebristo merged commit 5db3c2a into main Jul 29, 2022
@mebristo mebristo deleted the mebristo/more_smoke_tests branch July 29, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants