Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Enable custom SSL encoder checkpoint #562

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Conversation

mebristo
Copy link
Member

@mebristo mebristo commented Aug 8, 2022

Add command line arg to enable custom SSL encoder checkpoint

This also allows us to add an additional smoke test for TcgaCrckSslMil which requires a checkpoint for the encoder

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #562 (bffcc88) into main (539c8f4) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

Flag Coverage Δ
hi-ml-cpath 77.30% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...alth_cpath/configs/classification/DeepSMILECrck.py 68.75% <0.00%> (ø)
...gs/classification/DeepSMILESlidesPandaBenchmark.py 63.79% <ø> (ø)
...src/health_cpath/configs/classification/BaseMIL.py 77.23% <50.00%> (-0.19%) ⬇️
...lth_cpath/configs/classification/DeepSMILEPanda.py 83.56% <100.00%> (ø)

@mebristo mebristo marked this pull request as ready for review August 8, 2022 13:01
Copy link
Contributor

@kenza-bouzid kenza-bouzid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a quick question about the mock container

hi-ml-cpath/testhisto/testhisto/mocks/container.py Outdated Show resolved Hide resolved
hi-ml-cpath/Makefile Outdated Show resolved Hide resolved
@mebristo mebristo merged commit d5cb785 into main Aug 8, 2022
@mebristo mebristo deleted the mebristo/custom_ckpt_ssl branch August 8, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants