Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Enable logging to AzureML when running training outside AzureML #580

Merged
merged 18 commits into from
Sep 2, 2022
Merged

ENH: Enable logging to AzureML when running training outside AzureML #580

merged 18 commits into from
Sep 2, 2022

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Aug 18, 2022

Closes #579

@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

Merging #580 (4ec3f22) into main (0d66cec) will increase coverage by 0.08%.
The diff coverage is 81.03%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 81.80% <82.45%> (+0.10%) ⬆️
hi-ml-cpath 77.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/utils.py 25.87% <0.00%> (ø)
hi-ml/src/health_ml/experiment_config.py 100.00% <ø> (ø)
hi-ml/src/health_ml/runner.py 81.61% <0.00%> (ø)
hi-ml/src/health_ml/utils/logging.py 95.43% <82.35%> (+0.14%) ⬆️
hi-ml/src/health_ml/run_ml.py 75.80% <88.46%> (+0.51%) ⬆️
hi-ml/src/health_ml/configs/hello_world.py 87.28% <100.00%> (+0.10%) ⬆️
hi-ml/src/health_ml/deep_learning_config.py 87.86% <100.00%> (+0.17%) ⬆️
hi-ml/src/health_ml/lightning_container.py 85.22% <100.00%> (+0.52%) ⬆️
hi-ml/src/health_ml/model_trainer.py 76.47% <100.00%> (+0.56%) ⬆️

kenza-bouzid
kenza-bouzid reviewed Aug 23, 2022
View reviewed changes
hi-ml/src/health_ml/deep_learning_config.py Show resolved Hide resolved
hi-ml/src/health_ml/deep_learning_config.py Show resolved Hide resolved
hi-ml/src/health_ml/experiment_config.py Show resolved Hide resolved
hi-ml/src/health_ml/run_ml.py Show resolved Hide resolved
hi-ml/src/health_ml/utils/logging.py Outdated Show resolved Hide resolved
hi-ml/testhiml/testhiml/test_run_ml.py Outdated Show resolved Hide resolved
hi-ml/testhiml/testhiml/utils/test_logging.py Outdated Show resolved Hide resolved
mebristo
mebristo reviewed Aug 23, 2022
View reviewed changes
docs/source/runner.md Outdated Show resolved Hide resolved
@ant0nsc ant0nsc merged commit 1efdced into main Sep 2, 2022
@ant0nsc ant0nsc deleted the antonsc/log_on_vm branch September 2, 2022 12:35
ant0nsc added a commit that referenced this pull request Sep 13, 2022
@ant0nsc
ENH: Enable logging to AzureML when running training outside AzureML (#…
1f965e4 
…580)
This was referenced Sep 13, 2022
Closed
Merged
ant0nsc added a commit that referenced this pull request Sep 13, 2022
@ant0nsc
ENH: Add essential changes from main (#602)
822faf0 
* ENH: Enable logging to AzureML when running training outside AzureML (#580)
* FIX: Update env var settings for multi node (#588)
* ENH: Add a way of quickly starting runs with different seeds (#597)
* ENH: Submit jobs to Singularity via Amulet (#596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenza-bouzid kenza-bouzid kenza-bouzid left review comments

@vale-salvatelli vale-salvatelli vale-salvatelli approved these changes

@mebristo mebristo mebristo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable logging to AzureML when using the runner on a VM
4 participants
@ant0nsc @vale-salvatelli @kenza-bouzid @mebristo