Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Enable Global Similarity Comparison Between Text and Image Inputs #606

Merged
merged 15 commits into from
Sep 16, 2022

Conversation

ozan-oktay
Copy link
Contributor

#604
Proposed changes:

  • Image inference engine returns global image embeddings if user needs to compute image and sentence level alignment.
  • Similarly, VLP engine can use this method to return a single cosine similarity score as in CLIP method.

Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ozan-oktay. It would be best to make the methods slightly more modular: one function to load, one function to transform, one function to compute embeddings. This will maximise flexibility and simplify testing. I'm happy to work on that if you like.

@ozan-oktay
Copy link
Contributor Author

ozan-oktay commented Sep 15, 2022

Thanks, @ozan-oktay. It would be best to make the methods slightly more modular: one function to load, one function to transform, one function to compute embeddings. This will maximise flexibility and simplify testing. I'm happy to work on that if you like.

@fepegar The PR is not introducing any new loading or transformation functions -- It's using the existing class methods to return a global embedding that is similar to patch embedding computation. It also adds a separate method in VLP inference engine to return a similarity score. Please feel free to create a separate issue for the idea you have in mind, and if there is something particularly applicable within this context, please let me know. Thanks.

@ozan-oktay ozan-oktay removed the request for review from ant0nsc September 15, 2022 13:23
@fepegar fepegar enabled auto-merge (squash) September 16, 2022 10:53
@fepegar fepegar merged commit 9ccb647 into main Sep 16, 2022
@fepegar fepegar deleted the ozoktay/multimodal_global_similarities branch September 16, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants