Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix create v2 asset bug #772

Merged
merged 9 commits into from
Jan 27, 2023
Merged

Conversation

peterhessey
Copy link
Contributor

Closes #757 and #753

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #772 (1f46d9f) into main (df2314b) will decrease coverage by 0.03%.
The diff coverage is 22.22%.

Impacted file tree graph

Flag Coverage Δ
hi-ml 82.24% <ø> (ø)
hi-ml-cpath 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hi-ml-azure/src/health_azure/himl.py 25.00% <0.00%> (-0.08%) ⬇️
hi-ml-azure/src/health_azure/datasets.py 35.89% <33.33%> (-0.31%) ⬇️

@peterhessey peterhessey marked this pull request as ready for review January 27, 2023 11:46
hi-ml-azure/src/health_azure/himl.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/himl.py Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/datasets.py Outdated Show resolved Hide resolved
@peterhessey peterhessey force-pushed the phessey/fix-v2-asset-retrieval branch 2 times, most recently from c4ac724 to 1f46d9f Compare January 27, 2023 14:46
@peterhessey peterhessey merged commit 4fa4804 into main Jan 27, 2023
@peterhessey peterhessey deleted the phessey/fix-v2-asset-retrieval branch January 27, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Retrieving a V2 data asset reads version 1 by default
3 participants