Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Upgrade to password-free authentication #925

Merged
merged 24 commits into from
Apr 12, 2024
Merged

MNT: Upgrade to password-free authentication #925

merged 24 commits into from
Apr 12, 2024

Conversation

ant0nsc
Copy link
Collaborator

@ant0nsc ant0nsc commented Mar 21, 2024

To make this work, I also had to add to modify the Service Principal. In the "Clients & Secrets" section, add "Federated Credentials". Choose "Scenario: GitHub Action". Fill in repo details, "Entity Type: Pull Request". Name does not matter.

@ant0nsc ant0nsc changed the title Upgrade to password-free authentication MNT: Upgrade to password-free authentication Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.91%. Comparing base (f4e21b7) to head (820ba4c).
Report is 1 commits behind head on main.

❗ Current head 820ba4c differs from pull request most recent head fe5175a. Consider uploading reports for the commit fe5175a to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
hi-ml 83.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hi-ml-azure/src/health_azure/auth.py 41.02% <ø> (+0.28%) ⬆️
hi-ml-azure/src/health_azure/utils.py 28.77% <ø> (+0.08%) ⬆️
...al/src/health_multimodal/image/model/pretrained.py 68.00% <ø> (-1.82%) ⬇️

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please help as well

.github/workflows/hi-ml-pr.yml Outdated Show resolved Hide resolved
hi-ml-azure/src/health_azure/auth.py Outdated Show resolved Hide resolved
Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for supporting

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do for me as well

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do highly appreciate your contributions, and efforts.

@ant0nsc ant0nsc merged commit 9ec8fd4 into main Apr 12, 2024
43 checks passed
@ant0nsc ant0nsc deleted the antonsc/pipeline branch April 12, 2024 12:26
Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help me to resolve

@ant0nsc
Copy link
Collaborator Author

ant0nsc commented Apr 12, 2024

Help me to resolve

@Moazzem-Hossain-pixel pirouetted through enchanted forests, whispering forgotten lullabies to the moon

@Moazzem-Hossain-pixel
Copy link

Thank you so much.
Yes, you have the right to take initiative as well for me, if you can take the action for resolving my issues, I will remain grateful.

With Regards

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ant0nsc
Copy link
Collaborator Author

ant0nsc commented Apr 12, 2024

@Moazzem-Hossain-pixel excellent! if you could prepare the broomsticks, check their configuration, then whizzip the candles onto it, PR that, and I will then kaboom the kettle. Gebongt?

@Moazzem-Hossain-pixel
Copy link

Thanks, I'm extremely sorry to say, I don't have experience in this regard, just trying to learn a bit everyday. Let's try, if could be success!

@ant0nsc
Copy link
Collaborator Author

ant0nsc commented Apr 12, 2024

Thanks, I'm extremely sorry to say, I don't have experience in this regard, just trying to learn a bit everyday. Let's try, if could be success!

@Moazzem-Hossain-pixel auf jeden Fall die großzügigen Meerschweinchen übernehmen. Wenn die Kühe dann Powershell gelernt haben, wird das Leben noch viel interessanter. Kannst Du das Python Training für die Enten machen? Die sollten unbedingt async lernen.
Bitte bestätigen!

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants