New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded Comparison Sampling spec #147
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This documents how expanded comparison sampling should be implemented and what interfaces it should present to the shader author, the driver developer, and the runtime developer. In addition it outlines what new behaviors the compiler will have and how they should be tested.
python3kgae
reviewed
Jan 3, 2024
tex3d
reviewed
Jan 3, 2024
tex3d
reviewed
Jan 3, 2024
tex3d
reviewed
Jan 3, 2024
tex3d
reviewed
Jan 3, 2024
tex3d
reviewed
Jan 6, 2024
tex3d
reviewed
Jan 6, 2024
tex3d
reviewed
Jan 6, 2024
tex3d
reviewed
Jan 6, 2024
llvm-beanz
reviewed
Jan 8, 2024
Move most of the introduction section to motivation section where it fits better and doesn't exceed the length guidance. Renamed the arity suffixes on potentially multiple element vectors to be consistent. Listed accepted resources instead of excluded ones
tex3d
reviewed
Jan 18, 2024
tex3d
reviewed
Jan 18, 2024
tex3d
reviewed
Jan 18, 2024
llvm-beanz
approved these changes
Jan 24, 2024
The number is still uncertain and this conforms to protocol
make all MIP references capitalized. reword CaclulateLevelOfDetail test description. update name and location of cap bit.
tex3d
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents how expanded comparison sampling should be implemented and what interfaces it should present to the shader author, the driver developer, and the runtime developer. In addition it outlines what new behaviors the compiler will have and how they should be tested.