Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcm cask: Add arm64 support #66

Merged
merged 1 commit into from
Aug 11, 2022
Merged

gcm cask: Add arm64 support #66

merged 1 commit into from
Aug 11, 2022

Conversation

ldennington
Copy link
Contributor

Update git-credential-manager-core cask to determine whether to install
the x64 pkg or the arm64 pkg based on the user's CPU.

@ldennington ldennington self-assigned this Jul 14, 2022
@ldennington
Copy link
Contributor Author

ldennington commented Jul 14, 2022 •
edited
Loading

I feel pretty good about this based on my local testing on my Intel Mac. However, I'd love for @mjcheetham to test on his Apple Silicon machine before we ship 😁.

Edit: Never mind - this may require some updates for the SHA256 value. Converted back to draft.

@ldennington ldennington marked this pull request as draft July 14, 2022 19:09
@ldennington ldennington marked this pull request as draft July 14, 2022 19:09
@ldennington ldennington marked this pull request as ready for review July 20, 2022 20:22
@ldennington
Copy link
Contributor Author

@mjcheetham - I've tested the latest addition (prefix) on my Intel machine, but maybe you can test on your arm64 Mac? This is what I did to test:

brew uninstall git-credential-manager-core
brew untap microsoft/git -f
brew tap ldennington/tap
brew reinstall git-credential-manager-core
brew uninstall git-credenital-manager-core

Note: The uninstall script may fail without these changes applied.

@ldennington
gcm cask: Add arm64 support
ba3c42f 
Update git-credential-manager-core cask to determine whether to install
the x64 pkg or the arm64 pkg based on the user's CPU.
mjcheetham
mjcheetham approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! You can merge once the other dependant PRs are ready/merged.

@ldennington ldennington merged commit a71ce4a into microsoft:master Aug 11, 2022
@ldennington ldennington mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcheetham mjcheetham mjcheetham approved these changes

Assignees

@ldennington ldennington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldennington @mjcheetham