Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel missing from requirements.txt #60

Closed
markusweimer opened this issue May 11, 2020 · 8 comments
Closed

wheel missing from requirements.txt #60

markusweimer opened this issue May 11, 2020 · 8 comments

Comments

@markusweimer
Copy link
Member

I tried to run the following on a fresh VS Code Spaces instance:

$ pip install -r requirements.txt

And got the following errors:

Could not build wheels for numpy, since package 'wheel' is not installed.
Could not build wheels for scikit-learn, since package 'wheel' is not installed.
Could not build wheels for torch, since package 'wheel' is not installed.
Could not build wheels for xgboost, since package 'wheel' is not installed.
Could not build wheels for lightgbm, since package 'wheel' is not installed.
Could not build wheels for onnxconverter-common, since package 'wheel' is not installed.
Could not build wheels for scipy, since package 'wheel' is not installed.
Could not build wheels for joblib, since package 'wheel' is not installed.
Could not build wheels for future, since package 'wheel' is not installed.
Could not build wheels for protobuf, since package 'wheel' is not installed.
Could not build wheels for onnx, since package 'wheel' is not installed.
Could not build wheels for six, since package 'wheel' is not installed.
Could not build wheels for setuptools, since package 'wheel' is not installed.
Could not build wheels for typing-extensions, since package 'wheel' is not installed.

A quick

$ pip install wheel

Fixed that. Should wheel be in requirements.txt?

@interesaaat
Copy link
Collaborator

Interesting. Let me try to replicate the problem and yes, I will add wheel to the requirements in case.

@ksaur
Copy link
Collaborator

ksaur commented May 11, 2020

I'm about confused on this; we don't take a direct dependency on wheel. This seems more like a problem with the pip installation than Hummingbird if I'm not mistaken.

@markusweimer
Copy link
Member Author

Maybe wheel is usually expected to be there?

@ksaur
Copy link
Collaborator

ksaur commented May 11, 2020

@markusweimer - Did you run python -m pip install --upgrade pip when you setup pip?

@markusweimer
Copy link
Member Author

No, I did not.

@ksaur
Copy link
Collaborator

ksaur commented May 11, 2020

I haven't been able to reproduce this. Can you please explain the exact steps you tried?

@markusweimer
Copy link
Member Author

I created a new Codespace here and gave it the Hummingbird repo to setup from. It generated a venv with Python 3.7. That venv lacked the wheel installtion.

I believe this venv was created by Oryx. I believe that because the documentation for codespaces says so when explaining the default of the postCreateCommand option:

By default, oryx build is run. To disable Oryx behavior, set the value to empty string ("") or empty array ([]).

@ksaur
Copy link
Collaborator

ksaur commented May 12, 2020

The reason that I was not able to access codespaces is because the quota limit on our sub seems to be 1 codespace. I was able to create the codespace in another sub and verify that pip update fixes the issue.

@ksaur ksaur closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants