Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Visual Studio Codespaces #61

Closed
markusweimer opened this issue May 11, 2020 · 6 comments
Closed

Add support for Visual Studio Codespaces #61

markusweimer opened this issue May 11, 2020 · 6 comments

Comments

@markusweimer
Copy link
Member

One way to resolve #60 is to add explicit support for dev containers to the Hummingbird repo. The documentation for that is here. Specifically, we could add a Dockerfile and settings for VS Code to use it. I am happy to give that a try if someone has a Dockerfile I can base that on.

@ksaur
Copy link
Collaborator

ksaur commented May 11, 2020

I cannot access Visual Studio Codespaces. But here is https://github.com/microsoft/hummingbird/blob/kasaur/docker/Dockerfile

@markusweimer
Copy link
Member Author

Thanks! I have fiddled around a bit and made this:

https://github.com/markusweimer/hummingbird/tree/devcontainer/.devcontainer

Is there interest to have this as a PR?

@ksaur
Copy link
Collaborator

ksaur commented May 12, 2020

Yes, that would be great, thank you!

@ksaur
Copy link
Collaborator

ksaur commented May 12, 2020

Closing via PR #71

@ksaur ksaur closed this as completed May 12, 2020
@interesaaat
Copy link
Collaborator

Can we have a documentation on how to use this thing in CONTRIBUTING.md?

@ksaur
Copy link
Collaborator

ksaur commented May 12, 2020

writing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants