add LGBMRanker #173
add LGBMRanker #173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 93.57% 93.57%
=======================================
Files 25 25
Lines 1572 1573 +1
Branches 290 290
=======================================
+ Hits 1471 1472 +1
Misses 60 60
Partials 41 41
Continue to review full report at Codecov.
|
|
This was quick! |
tests/test_lightgbm_converter.py
Outdated
| # Ranker | ||
| @unittest.skipIf(not lightgbm_installed(), reason="LightGBM test requires LightGBM installed") | ||
| def test_lgbm_binary_ranker_converter(self): | ||
| # Using 30 rather than 1000 to avoid "label (31) excel the max range" error |
There was a problem hiding this comment.
What is this? Any idea?
There was a problem hiding this comment.
I followed the instructions to set label_gain without luck microsoft/LightGBM#1090
There was a problem hiding this comment.
I can try again Monday! Maybe there is something minor I was missing
There was a problem hiding this comment.
Ok let's leave this test as is. Can you add one more with label_gain once you figure it out? I will then merge it!
There was a problem hiding this comment.
figured out label_gain=list(range(1000)). should be ok now i think
Adding
LGBMRankerfor Issue #172