Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #715 by moving the wheel building to the Build TVM if Mac step #718

Merged
merged 1 commit into from Jun 23, 2023
Merged

Fix #715 by moving the wheel building to the Build TVM if Mac step #718

merged 1 commit into from Jun 23, 2023

Conversation

mshr-h
Copy link
Collaborator

@mshr-h mshr-h commented Jun 23, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #718 (4620d15) into main (eaac74f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #718   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files          80       80           
  Lines        4674     4674           
  Branches      855      855           
=======================================
  Hits         4218     4218           
  Misses        259      259           
  Partials      197      197
Flag Coverage Δ
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mshr-h mshr-h marked this pull request as ready for review June 23, 2023 07:31
@mshr-h mshr-h requested review from interesaaat and ksaur June 23, 2023 07:32
@ksaur ksaur linked an issue Jun 23, 2023 that may be closed by this pull request
TVM MacOS pipeline intermittent failures #715
Closed
ksaur
ksaur approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@ksaur ksaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thank you!

@ksaur ksaur merged commit 7f4db05 into microsoft:main Jun 23, 2023
10 checks passed
@ksaur ksaur mentioned this pull request Jul 11, 2023
Closed
ksaur added a commit that referenced this pull request Jul 11, 2023
@ksaur
Revert "move the wheel building to the Build TVM if Mac step (#718)"
91803a5 
This reverts commit 7f4db05.
ksaur added a commit that referenced this pull request Jul 11, 2023
@ksaur
Revert "move the wheel building to the Build TVM if Mac step (#718)"
0956b7b 
This reverts commit 7f4db05.
@mshr-h mshr-h deleted the fix-715 branch October 16, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksaur ksaur ksaur approved these changes

@interesaaat interesaaat Awaiting requested review from interesaaat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TVM MacOS pipeline intermittent failures
3 participants
@mshr-h @codecov-commenter @ksaur