Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKL 1.5.0 changes #774

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

SKL 1.5.0 changes #774

wants to merge 2 commits into from

Conversation

ksaur
Copy link
Collaborator

@ksaur ksaur commented May 30, 2024

@ksaur
Copy link
Collaborator Author

ksaur commented May 30, 2024

Ok the decomposition bug is definitely fixed!

I am a bit confused about the bagging changes (scikit-learn/scikit-learn#28432) I don't see what would have broken our code. Can you please take a look @interesaaat; I think you know this op best.

=========================== short test summary info ============================
FAILED tests/test_sklearn_bagging.py::TestSklearnBagging::test_bagging_logistic_regression - AssertionError: 
Not equal to tolerance rtol=1e-06, atol=1e-06

Mismatched elements: 200 / 200 (100%)
Max absolute difference: 0.99875297
Max relative difference: 0.99875297
 x: array([[9.809476e-01, 1.905245e-02],
       [9.987530e-01, 1.247026e-03],
       [8.200397e-01, 1.799603e-01],...
 y: array([[0., 1.],
       [0., 1.],
       [0., 1.],...
====== 1 failed, 389 passed, 275 skipped, 59 warnings in 89.85s (0:01:29) ======

It seems that there is some type/rounding issue?

@ksaur ksaur added the help wanted Extra attention is needed label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAILED tests/test_sklearn_bagging.py::TestSklearnBagging::test_bagging_logistic_regression - AssertionError
1 participant