Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Deduplicate getIndexesForPlan() and findCoveringIndexes() functions which are duplicated in FilterIndexRule and JoinIndexRule #51

Closed
pirz opened this issue Jun 24, 2020 · 1 comment · Fixed by #89
Closed

Deduplicate getIndexesForPlan() and findCoveringIndexes() functions which are duplicated in FilterIndexRule and JoinIndexRule #51

pirz opened this issue Jun 24, 2020 · 1 comment · Fixed by #89
Assignees
@sezruby
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
0.2.0

Comments

@pirz
Copy link
Contributor

pirz commented Jun 24, 2020

Describe the issue

FilterIndexRule.findCoveringIndexes() function and JoinIndexRule.getIndexesForPlan() function are similar in implementation.
Refactor them as common code in a single function and change the classes to use that.

To Reproduce

NA

Expected behavior

FilterIndex rule and JoinIndex rule implementation under rules should not have duplicate code for finding covering indexes.

Environment

NA
@pirz pirz added untriaged This is the default tag for a newly created issue enhancement New feature or request and removed untriaged This is the default tag for a newly created issue labels Jun 24, 2020
@pirz pirz changed the title Deduplicate getIndexesForPlan() function which is duplicated in FilterIndexRule and JoinIndexRule Deduplicate getIndexesForPlan() and findCoveringIndexes() functions which are duplicated in FilterIndexRule and JoinIndexRule Jun 24, 2020
@rapoth rapoth added this to the 0.3.0 milestone Jun 26, 2020
@rapoth rapoth added the good first issue Good for newcomers label Jul 8, 2020
@rapoth
Copy link
Contributor

rapoth commented Jul 9, 2020 •
edited

CC: @sezruby

@rapoth rapoth modified the milestones: 0.3.0, 0.2.0 Jul 9, 2020
sezruby added a commit to sezruby/hyperspace that referenced this issue Jul 14, 2020
@sezruby
Deduplicate getIndexesForPlan and findCoveringIndexes (microsoft#51)
324e234
@sezruby sezruby mentioned this issue Jul 14, 2020
Merged
sezruby added a commit to sezruby/hyperspace that referenced this issue Jul 18, 2020
@sezruby
Deduplicate getIndexesForPlan and findCoveringIndexes (microsoft#51)
4a9be0d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sezruby sezruby

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Deduplicate getIndexesForPlan and findCoveringIndexes sezruby/hyperspace
3 participants
@pirz @rapoth @sezruby