Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a clock trait in index cache #67

Closed
pirz opened this issue Jun 24, 2020 · 2 comments
Closed

Use a clock trait in index cache #67

pirz opened this issue Jun 24, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pirz
Copy link
Contributor

pirz commented Jun 24, 2020

Describe the issue

Add clock trait to the code and modify CreationTimeBasedIndexCache to use the clock with System time by default. Tests cases under IndexCacheTest should be modified to not use Thread.sleep.

To Reproduce

NA

Expected behavior

CreationTimeBasedIndexCache should be modified to use a clock.

Thread.sleep usage should be removed from index cache test cases.

Environment
@pirz pirz added untriaged This is the default tag for a newly created issue enhancement New feature or request and removed untriaged This is the default tag for a newly created issue labels Jun 24, 2020
@pirz pirz mentioned this issue Jun 24, 2020
Open
@rapoth rapoth added the good first issue Good for newcomers label Oct 29, 2020
@thugsatbay thugsatbay mentioned this issue Jan 6, 2021
Merged
@clee704
Copy link
Contributor

clee704 commented Mar 30, 2021

Is it still open?

@sezruby
Copy link
Collaborator

sezruby commented Mar 30, 2021

closed by #313

@sezruby sezruby closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clee704 @pirz @rapoth @sezruby