This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Use Hadoop yarn clock utils for all time based calculations #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2021 13:18
imback82
reviewed
Jan 7, 2021
src/main/scala/com/microsoft/hyperspace/index/CachingIndexCollectionManager.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/CachingIndexCollectionManager.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/CachingIndexCollectionManager.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/IndexCacheFactory.scala
Outdated
Show resolved
Hide resolved
src/main/scala/com/microsoft/hyperspace/index/IndexCacheFactory.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/IndexCacheTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/IndexCacheTest.scala
Outdated
Show resolved
Hide resolved
src/test/scala/com/microsoft/hyperspace/index/IndexCacheTest.scala
Outdated
Show resolved
Hide resolved
…into clock-time
imback82
reviewed
Jan 8, 2021
There was a problem hiding this comment.
@thugsatbay Can you first go over the changes and make sure unnecessary formatting changes are not introduced? I see too many to review. Thanks.
imback82
reviewed
Jan 14, 2021
There was a problem hiding this comment.
LGTM (one question), thanks @thugsatbay!
@sezruby Can you also take a look?
sezruby
reviewed
Jan 14, 2021
src/test/scala/com/microsoft/hyperspace/index/IndexCacheTest.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: EJ Song <51077614+sezruby@users.noreply.github.com>
imback82
approved these changes
Jan 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context for this pull request?
Use hadoop yarn utils clock for all time based calculations, also makes it easy during testing.
What changes were proposed in this pull request?
Just using inbuilt utils of hadoop lib for getting time.
Does this PR introduce any user-facing change?
None
How was this patch tested?
Unit tests were modified to test changes.