Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

[WIP] Support for Spark 3.0 #85

Closed
wants to merge 15 commits into from
Closed

Conversation

imback82
Copy link
Contributor

@imback82 imback82 commented Jul 9, 2020

What changes were proposed in this pull request?

This PR proposes to support Spark 3.0. I will share more about branching strategies, etc. as a separate PR.

Why are the changes needed?

To support Spark 3.0.

Does this PR introduce any user-facing change?

Yes. The user needs to consume this library along with Spark 3.0. This is not compatible with Scala 2.11 any longer.

How was this patch tested?

Updated existing tests.

@imback82 imback82 marked this pull request as draft July 9, 2020 04:58
@imback82 imback82 self-assigned this Jul 9, 2020
@imback82 imback82 added breaking changes enhancement New feature or request labels Jul 9, 2020
@sezruby
Copy link
Collaborator

sezruby commented Jul 27, 2020

Do you have any plan for code management of both spark 2.4.6 and 3.0.0?
I think we should manage different codebases for spark2.4.6 and 3.0.0 and provide build.sbt option accordingly.

@imback82
Copy link
Contributor Author

The current plan is to have 3.0 support in master and create a branch-2.4 for 2.4 support. The development process is to create a PR against master and merge it to both master/branch-2.4.

@sezruby
Copy link
Collaborator

sezruby commented Jul 28, 2020

That should be fine for developers :)

@imback82 imback82 marked this pull request as ready for review August 14, 2020 05:34
build.sbt Show resolved Hide resolved
@imback82 imback82 added this to the 0.3.0 milestone Aug 21, 2020
@rapoth rapoth modified the milestones: 0.3.0, 0.5.0 Sep 17, 2020
@imback82 imback82 closed this Oct 8, 2020
@imback82 imback82 reopened this Oct 8, 2020
@imback82 imback82 closed this Oct 8, 2020
@imback82 imback82 reopened this Oct 8, 2020
@imback82 imback82 modified the milestones: October 2020, November 2020 Oct 13, 2020
@rapoth rapoth marked this pull request as draft December 10, 2020 23:46
@rapoth rapoth changed the title Support for Spark 3.0 [WIP]: Support for Spark 3.0 Dec 10, 2020
@rapoth rapoth changed the title [WIP]: Support for Spark 3.0 [WIP] Support for Spark 3.0 Dec 10, 2020
Comment on lines +49 to +50
.getSnapshot
.filesForScan(projection = Nil, location.partitionFilters)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sezruby in Delta 8.0, there were some changes in the API. Could you confirm if these changes are fine?

@imback82
Copy link
Contributor Author

@andrei-ionescu In Spark 3.0, DataSourceV2Relation signature has changed and takes in Table now. Could you help fixing the it?


[error] /home/vsts/work/1/s/src/main/scala/com/microsoft/hyperspace/index/sources/iceberg/IcebergRelation.scala:58: value source is not a member of org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation
[error]   override def allFiles: Seq[FileStatus] = plan.source match {
[error]                                                 ^
[error] /home/vsts/work/1/s/src/main/scala/com/microsoft/hyperspace/index/sources/iceberg/IcebergRelation.scala:66: value source is not a member of org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation
[error]   override def partitionBasePath: Option[String] = plan.source match {
[error]                                                         ^
[error] /home/vsts/work/1/s/src/main/scala/com/microsoft/hyperspace/index/sources/iceberg/IcebergRelation.scala:85: value source is not a member of org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation
[error]     plan.source match {
[error]          ^
[error] /home/vsts/work/1/s/src/main/scala/com/microsoft/hyperspace/index/sources/iceberg/IcebergRelation.scala:87: not found: type DataSourceOptions
[error]         val dsOpts = new DataSourceOptions(plan.options.asJava)
[error]                          ^

@imback82
Copy link
Contributor Author

closed by #421

@imback82 imback82 closed this Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants