Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading definition of QualifiedName expression #70

Closed
AndreyG opened this issue Sep 17, 2022 · 1 comment · Fixed by #71
Closed

Misleading definition of QualifiedName expression #70

AndreyG opened this issue Sep 17, 2022 · 1 comment · Fixed by #71

Comments

@AndreyG
Copy link
Contributor

AndreyG commented Sep 17, 2022

Definition of QualifiedName says (sec:ifc:ExprSort:QualifiedName)

The elements field designates the sequence of unqualified names (ExprSort::UnqualifiedId)...

but actually part of qualified name could be not only UnqualifiedId, but also TemplateId.
@GabrielDosReis
Copy link
Collaborator

You're right ExprSort::QualifiedNamed should really be renamed to reflect the C++ standards' qualified-id

GabrielDosReis added a commit to GabrielDosReis/ifc-spec that referenced this issue Sep 22, 2022
@GabrielDosReis
Clarify ExprtSort::QualifiedName
3adffe4 
The component are NOT restricted to `ExprSort::UnqualifiedId`.

Fix microsoft#70
@GabrielDosReis GabrielDosReis mentioned this issue Sep 22, 2022
Merged
GabrielDosReis added a commit that referenced this issue Sep 22, 2022
@GabrielDosReis
Clarify ExprtSort::QualifiedName (#71)
78c80a8 
The component are NOT restricted to `ExprSort::UnqualifiedId`.

Fix #70
GabrielDosReis added a commit that referenced this issue Sep 22, 2022
@GabrielDosReis
Clarify ExprtSort::QualifiedName (#71)
48cb121 
The component are NOT restricted to `ExprSort::UnqualifiedId`.

Fix #70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify ExprtSort::QualifiedName GabrielDosReis/ifc-spec
2 participants
@AndreyG @GabrielDosReis