Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to turn off Grammar and Translation buttons #195

Closed
cadi3s opened this issue Sep 8, 2020 · 4 comments
Closed

Add option to turn off Grammar and Translation buttons #195

cadi3s opened this issue Sep 8, 2020 · 4 comments
Assignees
@tylerthedeveloper
Labels
enhancement New feature or request ticketed-internal

Comments

@cadi3s
Copy link

cadi3s commented Sep 8, 2020

In a Learning Management System, some courses are about learning a different language.
In such cases reading an assignment in the original language with ImmersiveReader can be very helpful, but a teacher would not want their students to see the correct translation.
@tylerthedeveloper
Copy link
Contributor

@cadi3s do you envision passing options such as "disableGrammar" and or "disableTranslation" booleans ?

@tylerthedeveloper tylerthedeveloper self-assigned this Apr 28, 2021
@cadi3s
Copy link
Author

cadi3s commented Apr 29, 2021

Yes please!

@tylerthedeveloper
Copy link
Contributor

Ack - i am now tracking this internally.

Please note this is considered an enhancement so we dont have a timeline for it yet and will prioritize based on customer need

@tylerthedeveloper
Copy link
Contributor

@cadi3s will provide an update on this in the next few days

cristobal-buenrostro added a commit that referenced this issue Aug 26, 2021
@cristobal-buenrostro
changes for github issue #195
20cf221
@cristobal-buenrostro cristobal-buenrostro linked a pull request Sep 9, 2021 that will close this issue
changes for github issue #195 - new disableGrammar and disableTranslation options #283
Closed
cristobal-buenrostro added a commit that referenced this issue Sep 14, 2021
@cristobal-buenrostro
changes for github issue #195
654535a
Merged
dylankil pushed a commit that referenced this issue Oct 22, 2021
@cristobal-buenrostro
Adding disable grammar and translation options - github issue #195 (#285
67d60d8 
)

* changes for github issue #195

* adding cogsvcs updated from Kaiju plus edog dev case

* Delete cogsvcs.html

* removing whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tylerthedeveloper tylerthedeveloper

Labels
enhancement New feature or request ticketed-internal
Projects
None yet
Milestone
No milestone
3 participants
@tylerthedeveloper @dylankil @cadi3s