shellIntegration.bash incorrectly sources /etc/profile and ~/.bash_profile

[russelldavis]

Describe the bug
When starting is, it sources all three of ~/.bashrc, /etc/profile, and ~/.bash_profile. This is not how bash startup is supposed to work.

For interactive shells, bash either sources /etc/profile and ~/.bash_profile (for login shells), or ~/.bashrc only (for non-login shells). See https://www.gnu.org/software/bash/manual/bash.html#Bash-Startup-Files

is should act like a non-login shell and only source ~/.bashrc, i.e., these lines should be deleted:

inshellisense/shell/shellIntegration.bash

Lines 4 to 13 in 9db5bee

	if [ -r /etc/profile ]; then
	. /etc/profile
	fi
	if [ -r ~/.bash_profile ]; then
	. ~/.bash_profile
	elif [ -r ~/.bash_login ]; then
	. ~/.bash_login
	elif [ -r ~/.profile ]; then
	. ~/.profile
	fi

If you wanted, you could provide a --login option like bash does and instead load /etc/profile and ~/.bash_profile in that case, though I'm not sure there's a good use case for that.

Environment

• OS: macOS Sonoma
• Output of is --version: 0.0.1-rc.10
• Nodejs Version: 20.11.1
• Shell: bash
• Shell Version: 5.2.21

[cpendery]

Reopening this since I think adding the --login option could be useful for some users