Revert "Create patient resource using a deterministic id (#183)" #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0600d80.
pallar-ms
reviewed
Apr 22, 2022
| // The resource will be created if the resource with the given id does not already exist. | ||
| resource.Id = ComputeSha256(identifier); | ||
| return await FhirService.UpdateResourceAsync<TResource>(resource).ConfigureAwait(false); | ||
| return await FhirService.CreateResourceAsync(resource).ConfigureAwait(false); |
There was a problem hiding this comment.
nit: Can we add a TODO comment with the tracking item to revert this revert?
There was a problem hiding this comment.
Thanks for the suggestion. Going to track with a Github issue for now.
pallar-ms
approved these changes
Apr 22, 2022
|
Opened Issue #188 to track |
dustinburson
deleted the
personal/duburson/temp-revert-deterministic-id-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert deterministic id on Patient/Device create. Found limitations on certain implementations of FHIR search. Until those are resolved, reverting to original functionality.