Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Python package should not find .qs files recursively. #20

Closed
anpaz opened this issue Feb 28, 2019 · 3 comments
Closed

Python package should not find .qs files recursively. #20

anpaz opened this issue Feb 28, 2019 · 3 comments
Assignees
@anpaz
Labels
Area-Kernel Issue relates to the IQ# kernel. Area-Python Issue relates to the Python client for the IQ# kernel. good first issue Good for newcomers Kind-Enhancement New feature or request

Comments

@anpaz
Copy link
Member

anpaz commented Feb 28, 2019

Currently, the Python qsharp module recursively tries to find all .qs files in all subdirectories of the current working folder, which is causing some confusion as that's not normal Python behavior.

We should just load the .qs files under the current working folder and find some other mechanism to import/load files from other folders.
@cgranade cgranade transferred this issue from microsoft/QuantumLibraries Jul 11, 2019
@cgranade cgranade added Area-Kernel Issue relates to the IQ# kernel. Area-Python Issue relates to the Python client for the IQ# kernel. Kind-Enhancement New feature or request labels Jul 11, 2019
@anpaz anpaz mentioned this issue Aug 19, 2019
Closed
@cgranade
Copy link
Contributor

We've gotten some feedback from users that this causes unexpected behavior in the case that the folder containing an IQ# notebook or Python session also contains folders that the kernel doesn't have permissions to. As we work to implement a longer-term solution, it may also be good to handle that case better in the short term.

@bromeg bromeg added this to the On Deck milestone Aug 29, 2019
@bromeg bromeg added the good first issue Good for newcomers label Aug 29, 2019
@bromeg bromeg assigned bromeg and anpaz and unassigned bromeg Aug 29, 2019
@cgranade cgranade mentioned this issue Sep 6, 2019
Closed
@ScottCarda-MS ScottCarda-MS mentioned this issue Oct 21, 2019
Merged
@ScottCarda-MS
Copy link
Contributor

ScottCarda-MS commented Oct 21, 2019 •
edited

Quick fix PR for this issue is #49.

@cgranade
Copy link
Contributor

cgranade commented Nov 7, 2019

Closing since #49 is now in, and as the rest of the work is tracked as #24.

@cgranade cgranade closed this as completed Nov 7, 2019
@rmshaffer rmshaffer removed this from the On Deck milestone Apr 22, 2020
@rmshaffer rmshaffer mentioned this issue Jun 3, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anpaz anpaz

Labels
Area-Kernel Issue relates to the IQ# kernel. Area-Python Issue relates to the Python client for the IQ# kernel. good first issue Good for newcomers Kind-Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cgranade @rmshaffer @anpaz @bromeg @ScottCarda-MS