Workspace Loader Only Check Top Level Directory #49
Conversation
…eck for qs file in the top level folder.
|
PR for issue #20. |
ScottCarda-MS
requested review from
microsoftopensource,
anpaz and
cgranade
and removed request for
microsoftopensource
There was a problem hiding this comment.
This looks like a good fix, thanks for doing that, @ScottCarda-MS! As discussed offline, we'll need to mention this in release notes (+@natke and @bromeg) for awareness, and will need to check that no sample or kata code is broken (@bettinaheim and I for samples, @tcNickolas for katas).
|
Would it be possible to get instructions on how to check that this change doesn't break the katas? |
This change causes that, when called from IQ# or Python, all Q# code must be in the current working directory or in a referenced package. There should be an alpha package from this PR on the prerelease feed that will allow for testing, just need to make sure you have a NuGet.Config set up to point to that feed (this repo has an example of such a config in its root). |
|
@tcNickolas , I took a quick look at Katas, and all the .qs files are in the same folder as the notebook, so it should not affect them. |
|
@tcNickolas mentioned that this may cause issues with the DeutschJozsaAlgorithm kata. I am, at this time, unable to test this change against that kata. |
Changed the behavior of the workspace loader's file search to only check for qs file in the top level folder.