Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library doesn't work if SSL is used with a properly signed certificate. #9

Open
wjenkins1 opened this issue Aug 26, 2016 · 4 comments

Comments

@wjenkins1
Copy link

If I use https then I get a scheme is not registered error because the only way to add https as a permitted scheme is through use of a self-signed certificate. It would be better if there was an option that allowed the use of https (and then trusted a self-signed certificate if one was present).

@swells
Copy link
Member

swells commented Aug 26, 2016

Hello,

Yes your explanation makes sense. Let us have a look in order to reproduce
and fix if need be.

  • Sean

On Thu, Aug 25, 2016 at 6:59 PM, Wayne Jenkins notifications@github.com
wrote:

If I use https then I get a scheme is not registered error because the
only way to add https as a permitted scheme is through use of a self-signed
certificate. It would be better if there was an option that allowed the use
of https (and then trusted a self-signed certificate if one was present).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABSyP1SDgtUI0Hh8O1f_2fDBiHh2Ra0rks5qjkhvgaJpZM4Jtq6q
.

@wjenkins1
Copy link
Author

You can see the limitation in the RClientImpl.java. I cannot get https registered as a scheme unless I go via the self-signed route. I tried setting the flag but it didn't help. Cheers, Wayne.

    SchemeRegistry schemeRegistry = new SchemeRegistry();
    schemeRegistry.register(
        new Scheme("http", PlainSocketFactory.getSocketFactory(), 80));

    if(allowSelfSignedSSLCert) {

...
}

@wjenkins1
Copy link
Author

BTW We are using RServer in the cloud motivating the use of https. Our self-signed certificate didn't work so we were forced to use a real certificate. The issue we have now is that it doesn't work either. I will hack a solution for now within the RClientImpl.java file but it would be good if it was resolved in the future. Https needs to be supported in general.

@wjenkins1
Copy link
Author

I added the following line to the code above.
schemeRegistry.register(new Scheme("https", SSLSocketFactory.getSocketFactory(), 443));

The POST works for submitting a task but I cannot get the result of the computation for similar reasons. I have put it in the too hard basket for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants