Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing exports in just-scripts #745

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

christiango
Copy link
Member

Overview

On our team, we run our just scripts through typescript using // @ts-check comments.

For the new typescript 5.4 release candidate, we are getting errors like this when importing just like this:

const just = require('just-scripts');

The error messages:

TS9006: Declaration emit for this file requires using private name 'PrettierTaskOptions' from module '"D:/office-bohemia/node_modules/just-scripts/lib/tasks/prettierTask"'. An explicit type annotation may unblock declaration emit.

To resolve these, we're adding the missing exports for types that appear on the public API signature of just-scripts

Test Notes

Only an update to the types exports

@christiango christiango merged commit a5a2fea into master Mar 4, 2024
2 checks passed
@christiango christiango deleted the christiango/export-a-few-things branch March 4, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants