genpolicy: add support for cc-azurefile-csi driver #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmihai1
approved these changes
Apr 19, 2024
ms-mahuber
approved these changes
Apr 22, 2024
|
Verified it build on Windows and started test run https://dev.azure.com/mariner-org/mariner/_build/results?buildId=556262&view=results Edit: started new run after updating samples: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=556371&view=results |
sprt
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Could you update the samples using this script? https://github.com/microsoft/kata-containers/blob/msft-main/src/tools/genpolicy/update_policy_samples.py
sprt
approved these changes
Apr 23, 2024
src/tools/genpolicy/rules.rego
Outdated
| @@ -912,10 +912,18 @@ allow_storage_options(p_storage, i_storage, layer_ids, root_hashes) { | |||
|
|
|||
| p_storage.driver == "smb" | |||
| count(p_storage.options) == 0 | |||
There was a problem hiding this comment.
Is this not redundant assuming we trust genpolicy?
There was a problem hiding this comment.
I agree we don't need to check the count of policy arrays.
Redent0r
approved these changes
Apr 23, 2024
danmihai1
approved these changes
Apr 23, 2024
src/tools/genpolicy/rules.rego
Outdated
| @@ -912,10 +912,18 @@ allow_storage_options(p_storage, i_storage, layer_ids, root_hashes) { | |||
|
|
|||
| p_storage.driver == "smb" | |||
| count(p_storage.options) == 0 | |||
There was a problem hiding this comment.
I agree we don't need to check the count of policy arrays.
arc9693
force-pushed
the
archana1/azurefile-genpolicy
branch
2 times, most recently
from
141f180
to
3c303a3
Compare
This patch adds support for the cc-azurefile-csi driver to the genpolicy. Signed-off-by: Archana Choudhary <archana1@microsoft.com>
This patch updates policy samples, required after adding support for cc-azurefile-csi driver in genpolicy. Signed-off-by: Archana Choudhary <archana1@microsoft.com>
arc9693
force-pushed
the
archana1/azurefile-genpolicy
branch
from
14c07ee
to
b5d68be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for the cc-azurefile-csi driver to the genpolicy.
Merge Checklist
upstream-missinglabel (orupstream-not-needed) has been set on the PR.Summary
Associated issues
Links to CVEs
Test Methodology