virtcontainers: update sev_snp param serialization #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redent0r
force-pushed
the
saulparedes/update_sev_snp_param
branch
from
4855eca
to
dc45924
Compare
Update the sev parameter to sev_snp in the cloud-hypervisor.yaml file to match cloud-hypervisor 38.0.72. See https://github.com/microsoft/cloud-hypervisor/blob/msft/v38.0.72/vmm /src/config.rs#L687 Signed-off-by: Saul Paredes <saulparedes@microsoft.com>
Redent0r
force-pushed
the
saulparedes/update_sev_snp_param
branch
from
dc45924
to
57ab374
Compare
|
This change was tested in https://github.com/microsoft/kata-containers/commits/saulparedes/update_sev_snp_param2/, where it's rebased on top of last release (3.2.0.azl1) Buddy build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=578368&view=results Propietary buddybuild: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=576885&view=results image build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=578389&view=results conf test: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=578425 conf test rerun with updated samples: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=578771 |
Redent0r
added
the
upstream/not-needed
ms-mahuber
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sev_snp param serialization to make it
match against cloud-hypervisor v38.0.72.
See cloud-hypervisor/cloud-hypervisor#5628 s#diff-c235a65d9dfdc1392f1c9546df912679bbdd74138316a04d9cfd53ef8fe1f907R 527
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
Update plataform config param from
sevtosev_snpThis was done by updating cloud-hypervisor.yaml and running
make generate-client-code && make go-fmtTest Methodology