Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated MSExcelDecoder to handle blank cell values (#384)
Objective is to support excel files which has few blank values within the used range. Taking example of below excel ![image](https://github.com/microsoft/kernel-memory/assets/34688460/0b1ddbc2-4338-48c3-b423-88810fea1cb3) - Currently the code ignores the blank values, and that creates distortion in the arrangement of values. Output of the above excel file looks something like below ``` "EmployeeName", "EmployeeSalary", "EmployeeDepartment", "EmployeeCity", "EmployeeId" "John", 1000, "Accounts", "New York", 1 "Jack", 2000, "Tax", "Bangalore", 2 "Ryan", 3000, "HR", "Tokyo", 3 "Rob", 2000, "Tax", 4 "Pablo", 5000, "Accounts", "Paris", ``` (See the employee city for Rob has been substituted by the employee Id 4) - With the proposed change, a default value `Blank` will be substituted when these kinds of scenarios are observed. Consumers are free to overwrite the default value with the help of the newly introduced constructor variable ``` "EmployeeName", "EmployeeSalary", "EmployeeDepartment", "EmployeeCity", "EmployeeId" "John", 1000, "Accounts", "New York", 1 "Jack", 2000, "Tax", "Bangalore", 2 "Ryan", 3000, "HR", "Tokyo", 3 "Rob", 2000, "Tax", Blank, 4 "Pablo", 5000, "Accounts", "Paris", 5 ``` (See the employee city for Rob is substituted with `Blank`) --------- Co-authored-by: Neelambuj Banerjee <Neelambuj.Banerjee@gds.ey.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
- Loading branch information