Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Making sure touch events do not mistakenly trigger keyboard navigation mode. #80

Merged
merged 3 commits into from
May 3, 2024

Conversation

mshoho
Copy link
Member

@mshoho mshoho commented Apr 26, 2024

Keyborg sets keyboard navigation mode when focus is moved without using mouse. This PR fixes mistakenly going into keyboard navigation mode on iOS's touch events.

@mshoho mshoho requested a review from a team as a code owner April 26, 2024 16:33
Copy link

github-actions bot commented Apr 26, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
keyborg
All exports
6.413 kB
1.999 kB
6.859 kB
2.056 kB
446 B
57 B
keyborg
createKeyborg() & disposeKeyborg()
6.19 kB
1.951 kB
6.636 kB
2.005 kB
446 B
54 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
keyborg
KEYBORG_FOCUSIN constant
62 B
82 B
🤖 This report was generated against bdfc82f67b743c64e8d9ec0bfac50b75d72e9cef

Keyborg Build and others added 2 commits April 26, 2024 16:38
@mshoho mshoho changed the title Fix: Making sure touch events do not mistakenly trigger focus events. Fix: Making sure touch events do not mistakenly trigger keyboard navigation mode. May 2, 2024
@micahgodbolt
Copy link
Member

Customer was able to test and verify that this resolves the iOS situation.

@mshoho mshoho merged commit 0ac2a4a into main May 3, 2024
3 checks passed
@mshoho mshoho deleted the considering-touch branch May 3, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants