Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.Diagnostics.DiagnosticSource dependency from net 6+ #218

Closed
thompson-tomo opened this issue Apr 16, 2024 · 3 comments · Fixed by #220
Closed

Remove System.Diagnostics.DiagnosticSource dependency from net 6+ #218

thompson-tomo opened this issue Apr 16, 2024 · 3 comments · Fixed by #220
Assignees
Labels
enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
I want the package to not have an explicit dependency on System.Diagnostics.DiagnosticSource on net 6+.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a

@andrueastman
Copy link
Member

Thanks for raising this @thompson-tomo

Would you be willing to submit a PR similar to #219 for this?

@thompson-tomo
Copy link
Contributor Author

@andrueastman sure I will go through submitting PR's in the coming days.

@baywet baywet added the enhancement New feature or request label Apr 17, 2024
thompson-tomo added a commit to thompson-tomo/kiota-abstractions-dotnet that referenced this issue Apr 17, 2024
@thompson-tomo
Copy link
Contributor Author

Submitted as #220

andrueastman added a commit that referenced this issue Apr 18, 2024
…isation

#218 tweak when System.Diagnositics.DiagnosticSource is included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
3 participants