Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions in backing store #95

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Conversation

andrueastman
Copy link
Member

Closes microsoftgraph/msgraph-sdk-dotnet#1980

Changes store dictionaries to ConcurrentDictionary instance to alleviate race conditions from possible concurrent writes/accesses.

@andrueastman andrueastman requested a review from baywet June 22, 2023 11:35
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman merged commit 5092424 into main Jun 22, 2023
11 checks passed
@andrueastman andrueastman deleted the fix/raceConditions branch June 22, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client bug]: Not safe to use GraphServiceClient concurrently anymore (?)
2 participants