Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters with lists of numbers not supported in URIs #124

Merged
merged 2 commits into from Nov 24, 2023

Conversation

papegaaij
Copy link
Contributor

AddQueryParameters only checks for []string, []any and (slices of) enum types. Kiota however also constructs query parameters with types like []int64. These do not satisfy any of the current checks and are therefor never rendered in the resulting URI.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Can you also update the changelog please (new patch version, today's date, fix listed under a new changed section)

@papegaaij
Copy link
Contributor Author

Ah, sorry, I totally forgot. I had to create the PR first before I could add the reference in the changelog and forgot to update the changelog afterwards.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the change

@baywet baywet merged commit 920cc73 into microsoft:main Nov 24, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants