Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System.Diagnostics.DiagnosticSource dependency from net 6+ #191

Closed
thompson-tomo opened this issue Apr 16, 2024 · 1 comment · Fixed by #193
Closed

Remove System.Diagnostics.DiagnosticSource dependency from net 6+ #191

thompson-tomo opened this issue Apr 16, 2024 · 1 comment · Fixed by #193

Comments

@thompson-tomo
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like
I want the package to not have an explicit dependency on System.Diagnostics.DiagnosticSource on net 6+.

Describe alternatives you've considered
Accept the additional dependency

Additional context
n/a
@andrueastman
Copy link
Member

Related to microsoft/kiota-abstractions-dotnet#219

thompson-tomo added a commit to thompson-tomo/kiota-authentication-azure-dotnet that referenced this issue Apr 18, 2024
@thompson-tomo
microsoft#191 Optimise Dependencies
91dba46
@thompson-tomo thompson-tomo mentioned this issue Apr 18, 2024
Merged
andrueastman added a commit that referenced this issue Apr 19, 2024
@andrueastman
Merge pull request #193 from thompson-tomo/chore/#191_DependencyOptim…
79cda04 
…isation&Bump

#191 Optimise Dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#191 Optimise Dependencies thompson-tomo/kiota-authentication-azure-dotnet
2 participants
@andrueastman @thompson-tomo