Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- adds support for trimming #83

Merged
merged 3 commits into from
Nov 8, 2023
Merged

- adds support for trimming #83

merged 3 commits into from
Nov 8, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Oct 20, 2023

@baywet baywet self-assigned this Oct 20, 2023
@baywet baywet marked this pull request as ready for review November 7, 2023 15:05
@baywet baywet enabled auto-merge November 7, 2023 15:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

andrueastman
andrueastman reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Ping @calebkiage for final review before merge.

@baywet baywet merged commit 308727c into main Nov 8, 2023
9 checks passed
@baywet baywet deleted the feature/trimming branch November 8, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@calebkiage calebkiage calebkiage approved these changes

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@peombwa peombwa Awaiting requested review from peombwa

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

@rkodev rkodev Awaiting requested review from rkodev

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baywet @calebkiage @andrueastman