New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request config revamp #1520
request config revamp #1520
Conversation
c5d6e41
to
79af68b
Compare
@andrueastman as I suspected I was able to go through Go but not typescript. Thank you for taking this over the finish line while I'm gone. Here is a high level check-list to help out:
I think that's about it! |
No worries. Thanks for the tips @baywet |
26ace95
to
232d3bc
Compare
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
4273e9d
to
fa4241d
Compare
microsoft/kiota-typescript#146 (comment) cc @nikithauc |
Any chance I can get a second review? @MIchaelMainer @zengin @nikithauc @calebkiage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a couple of minor perf comments.
http/java/okhttp/lib/src/main/java/com/microsoft/kiota/http/OkHttpRequestAdapter.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Mustafa Zengin <muzengin@microsoft.com>
Thanks so much for taking a look @zengin. |
Kudos, SonarCloud Quality Gate passed! |
Thanks everyone for pushing this across the finish line while I was gone! 🥰 |
Fixes #1494
generation diff
microsoft/kiota-samples#625
Todo