Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- adds support for none key for serializer arguments #4086

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

baywet
Copy link
Member

@baywet baywet commented Jan 30, 2024

fixes #3796 cc @andreaTP

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet baywet requested a review from a team as a code owner January 30, 2024 16:36
@baywet baywet self-assigned this Jan 30, 2024
@baywet baywet enabled auto-merge January 30, 2024 16:36
Copy link

sonarcloud bot commented Jan 30, 2024

@andreaTP
Copy link
Contributor

Nice! Thanks for taking this @baywet !
Questions, do you plan to add guidance(e.g. examples/docs) on how to use this feature?
Or will it be up to the user/integrator to figure out what better fits his project?

@baywet
Copy link
Member Author

baywet commented Jan 30, 2024

thanks for the reminder, also authored this docs PR MicrosoftDocs/openapi-docs#60

@andreaTP
Copy link
Contributor

LGTM, I know what to do, I think it's not obvious for a newcomer, but it's anyhow an "advanced" usage unless we swap to none as default. I wish it, but it's not planned AFAIU.

Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@baywet baywet merged commit 801c779 into main Jan 31, 2024
185 of 187 checks passed
@baywet baywet deleted the feature/none-key branch January 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provide a none key for serializers and deserializers so no registration is done in the client
3 participants