Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug from generation of model names #4817

Merged
merged 10 commits into from
Jul 2, 2024
Merged

Fix bug from generation of model names #4817

merged 10 commits into from
Jul 2, 2024

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Jun 12, 2024

Models that were flattened, i.e moved from deeper packages to level 2 pakages relied on the package names to prefix the deeper model name. Chnages introduced by package name case normalization affecting camel casing in names.

This resolves microsoftgraph/msgraph-sdk-go#721

@rkodev rkodev requested a review from a team as a code owner June 12, 2024 08:12
SilasKenneth
SilasKenneth previously approved these changes Jun 12, 2024
@SilasKenneth SilasKenneth self-requested a review June 12, 2024 09:25
@SilasKenneth SilasKenneth dismissed their stale review June 12, 2024 09:26

There are failing tests for correcting the package name casing

baywet
baywet previously approved these changes Jun 12, 2024
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkodev can you queue a smoke generation to ensure this fixes the problem please?
Also I'd like us to add retract directives for the impacted versions.
https://go.dev/ref/mod#go-mod-file-retract

Copy link

sonarcloud bot commented Jul 1, 2024

@rkodev
Copy link
Contributor Author

rkodev commented Jul 1, 2024

@rkodev can you queue a smoke generation to ensure this fixes the problem please? Also I'd like us to add retract directives for the impacted versions. https://go.dev/ref/mod#go-mod-file-retract

Smoke generation with the fix https://github.com/microsoftgraph/msgraph-sdk-go/blob/v1.0/pipelinebuild/154506/users/item_get_member_groups_response.go#L12

https://dev.azure.com/microsoftgraph/Graph%20Developer%20Experiences/_build/results?buildId=154506&view=results

@rkodev rkodev merged commit 450e1eb into main Jul 2, 2024
207 checks passed
@rkodev rkodev deleted the fix/go-generation branch July 2, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done ✔️
Development

Successfully merging this pull request may close these issues.

release 1.44 breaks the api with no releasenotes or documentation updates
4 participants